EA not close all open psition with magic number

[michel picard]

Hi,

I note a strange behavior with my EA. Sometimes it closes the opened positions but without  magic number.

I tried to figure out why but I can't find the reason

I'm using the following code to open trade

trade.SetExpertMagicNumber(magic);
// ....
if(trade.PositionOpen(Symbol(),type,lot,ND(op),ND(sl), ND(tp),comment)){
 res=trade.ResultOrder();
// ....
}

and this one to make some calculation

   datetime today     = TimeCurrent() ;
   datetime yesterday = TimeCurrent() - (60 * 60 * 24);
   HistorySelect(0,TimeCurrent());
   for (int l = HistoryDealsTotal()-1; l >= 0; l--) {
      if(deal.SelectByIndex(l)) {
         if ( deal.Entry()==DEAL_ENTRY_OUT && deal.Symbol() == Symbol() ) {
            if ( deal.Magic() == magic) {
               double orderProfit = (deal.Profit() + deal.Swap() + deal.Commission());
               if( TimeDay(deal.Time()) == TimeDay(today) &&
                     TimeMonth(deal.Time()) == TimeMonth(today) &&
                     TimeYear (deal.Time()) == TimeYear(today) ) {
                  profitToday += orderProfit;
               }
               if( TimeDay  (deal.Time()) == TimeDay(yesterday) &&
                     TimeMonth(deal.Time()) == TimeMonth(yesterday) &&
                     TimeYear (deal.Time()) == TimeYear(yesterday) ) {
                  profitYesterday += orderProfit;
               }
            }
         }
      }
   }

I use the following code to close my orders

void CloseAllOrders() {
   for (int m = PositionsTotal()-1; m >= 0; m--) {
      if ( position.SelectByIndex(m)) {
         if(   position.Symbol() == Symbol() 
            && position.Magic() == magic) {

            bool success = trade.PositionClose(position.Ticket());
         }
      }
   }
}

When I use debugger some deal have magic number equal '0' but I don't closed them manually. They have been closed by the EA.
So I don't understand why

Someone can help me ?

[Vladimir Karputov]

Do you set the 'Magic number' for an object of the CTrade trade class? ( SetExpertMagicNumber )

[michel picard]

Vladimir Karputov:
Do you set the 'Magic number' for an object of the CTrade trade class? ( SetExpertMagicNumber )

Yes. Look at the first bloc code I posted

[Vladimir Karputov]

michel picard :

Yes. Look at the first bloc code I posted

I asked for a reason.

You are initializing to ' magic ' and the positions are trying to sort by ' magicbuy '.

[michel picard]

Vladimir Karputov:

I asked for a reason.

You are initializing to ' magic ' and the positions are trying to sort by ' magicbuy '.

My mistake. It's just typo bug  but yes it's magic everywhere.

PS: I edited my first post.