Making an indicator see the higher timeframe

To add comments, please log in or register
Ziad El
124
Ziad El  

I am editing the MQL5 downloadable indicator " MACD.mq5 " to make it show the higher time frame MACD instead of the current one, but with no success.

the main code I inserted is:

input bool FractalTime = true;                  // Fractal Application
//...
//...
//--- Get the proper timeframe depening on user requirement: 
ENUM_TIMEFRAMES T = 0;           
if (FractalTime==false) T = 0;
if (FractalTime==true)  T = PERIOD_M15; 

//--- get MA handles
ExtFastMaHandle=iMA(NULL,T,InpFastEMA,0,MODE_EMA,InpAppliedPrice);
ExtSlowMaHandle=iMA(NULL,T,InpSlowEMA,0,MODE_EMA,InpAppliedPrice);
//--- initialization done

However I am getting errors about:

Not all data of ExtFastMaHandle is calculated (100015bars ). Error4806


The full listing of the edited code is as follows:


//+------------------------------------------------------------------+
//|                                                         MACD.mq5 |
//|                        Copyright 2009, MetaQuotes Software Corp. |
//|                                              http://www.mql5.com |
//+------------------------------------------------------------------+
#property copyright   "2009, MetaQuotes Software Corp."
#property link        "http://www.mql5.com"
#property description "Moving Average Convergence/Divergence"
#include <MovingAverages.mqh>
#include <TicTac.mqh>

//--- indicator settings
#property indicator_separate_window
#property indicator_buffers 4
#property indicator_plots   2
#property indicator_type1   DRAW_HISTOGRAM
#property indicator_type2   DRAW_LINE
#property indicator_color1  Silver
#property indicator_color2  Red
#property indicator_width1  2
#property indicator_width2  1
#property indicator_label1  "MACD"
#property indicator_label2  "Signal"
//--- input parameters
input int                InpFastEMA=12;           // Fast  EMA  period
input int                InpSlowEMA=26;           // Slow  EMA  period
input int                InpSignalSMA=9;          // Signal SMA period
input ENUM_APPLIED_PRICE InpAppliedPrice=PRICE_CLOSE; // Applied price
input bool FractalTime = true;                  // Fractal Application
//--- indicator buffers
double                   ExtMacdBuffer[];
double                   ExtSignalBuffer[];
double                   ExtFastMaBuffer[];
double                   ExtSlowMaBuffer[];
//--- MA handles
int                      ExtFastMaHandle;
int                      ExtSlowMaHandle;
//+------------------------------------------------------------------+ 
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
void OnInit()
{
//--- indicator buffers mapping
SetIndexBuffer(0,ExtMacdBuffer,INDICATOR_DATA);
SetIndexBuffer(1,ExtSignalBuffer,INDICATOR_DATA);
SetIndexBuffer(2,ExtFastMaBuffer,INDICATOR_CALCULATIONS);
SetIndexBuffer(3,ExtSlowMaBuffer,INDICATOR_CALCULATIONS);
//--- sets first bar from what index will be drawn
PlotIndexSetInteger(1,PLOT_DRAW_BEGIN,InpSignalSMA-1);
//--- name for Dindicator subwindow label
IndicatorSetString(INDICATOR_SHORTNAME,"YAKMACD("+string(InpFastEMA)+
                 ","+string(InpSlowEMA)+","+string(InpSignalSMA)+")");
//--- Get the proper timeframe depening on user requirement: 
ENUM_TIMEFRAMES T = 0;           
if (FractalTime==false) T = 0;
if (FractalTime==true)  T = PERIOD_M15; 

//--- get MA handles
ExtFastMaHandle=iMA(NULL,T,InpFastEMA,0,MODE_EMA,InpAppliedPrice);
ExtSlowMaHandle=iMA(NULL,T,InpSlowEMA,0,MODE_EMA,InpAppliedPrice);
//--- initialization done
}
//+------------------------------------------------------------------+
//| Moving Averages Convergence/Divergence                           |
//+------------------------------------------------------------------+
int OnCalculate(const int rates_total,const int prev_calculated,
                const datetime &Time[],
                const double &Open[],
                const double &High[],
                const double &Low[],
                const double &Close[],
                const long &TickVolume[],
                const long &Volume[],
                const int &Spread[])
{
//--- check for data
if(rates_total<InpSignalSMA)                                return(0);
//--- not all data may be calculated
int calculated=BarsCalculated(ExtFastMaHandle);
if(calculated<rates_total)
{
 Print("Not all data of ExtFastMaHandle is calculated (",
  calculated,"bars ). Error",GetLastError());               return(0);
}
 calculated=BarsCalculated(ExtSlowMaHandle);
if(calculated<rates_total)
{
Print("Not all data of ExtSlowMaHandle is " " calculated (",
 calculated,"bars ). Error",GetLastError());                return(0);
}
//--- we can copy not all data
int to_copy;
if(prev_calculated>rates_total || prev_calculated<0) 
                                              to_copy=rates_total;
else
{
 to_copy=rates_total-prev_calculated;
 if(prev_calculated>0) to_copy++;
}
//--- get Fast EMA buffer
if(IsStopped()) return(0); //Checking for stop flag
 if(CopyBuffer(ExtFastMaHandle,0,0,to_copy,ExtFastMaBuffer)<=0)
 {
  Print("Getting fast EMA is failed! Error",GetLastError());
  return(0);
 }
//--- get SlowSMA buffer
if(IsStopped()) return(0); //Checking for stop flag
 if(CopyBuffer(ExtSlowMaHandle,0,0,to_copy,ExtSlowMaBuffer)<=0)
 {
  Print("Getting slow SMA is failed! Error",GetLastError());
  return(0);
 }
//---
int limit;
if(prev_calculated==0)                                        limit=0;
else                                          limit=prev_calculated-1;
//--- calculate MACD
for(int i=limit;i<rates_total && !IsStopped();i++)
 ExtMacdBuffer[i]=ExtFastMaBuffer[i]-ExtSlowMaBuffer[i];
//--- calculate Signal
SimpleMAOnBuffer(rates_total,prev_calculated,0,InpSignalSMA,
                                       ExtMacdBuffer,ExtSignalBuffer);
//--- OnCalculate done. Return new prev_calculated.
return(rates_total);
}
//+------------------------------------------------------------------+


Could you help please?

To add comments, please log in or register