Can't find bug, please help!

[[Deleted]]

I'm working on my first EA, it's almost done but there is 1 small problem..

When I use eachtickmode it orders twice:

EA orders -> EA closes order right away -> EA opens another order -> EA closes that order correctly.

I've been trying for 2 days to find the error that makes the EA close the initial order right away, I just want one order..

Here is the code

#property copyright "_1"

#property link      "http:///"



#define SIGNAL_NONE 0

#define SIGNAL_BUY   1

#define SIGNAL_SELL  2

#define SIGNAL_CLOSEBUY 3

#define SIGNAL_CLOSESELL 4



extern int MagicNumber = 0;

extern int MaxSpread = 40;

extern double Lots = 0.1;

extern int Slippage = 4;



extern bool SignalMail = False;

extern bool EachTickMode = True;

extern bool UseStopLoss = False;

extern bool UseTakeProfit = False;

extern bool UseTrailingStop = False;



extern int TakeProfit = 60;

extern int StopLoss = 10;

extern int TrailingStop = 30;



int timeprev;

int BarCount;

int Current;

bool TickCheck = False;



//+------------------------------------------------------------------+

//| expert initialization function                                   |

//+------------------------------------------------------------------+

int init() {

return(0);

}

//+------------------------------------------------------------------+

//| expert deinitialization function                                 |

//+------------------------------------------------------------------+

int deinit() {

   return(0);

}

//+------------------------------------------------------------------+

//| expert start function                                            |

//+------------------------------------------------------------------+

int start() {

   int Order = SIGNAL_NONE;

   int Total, Ticket;

   double StopLossLevel, TakeProfitLevel;

   double currentSpread = MarketInfo(Symbol(),MODE_SPREAD);

   

  if (EachTickMode && Bars != BarCount) TickCheck = False;

   Total = OrdersTotal();

   Order = SIGNAL_NONE;

   

  if (currentSpread>MaxSpread) {

      return;

      }



   //+------------------------------------------------------------------+

   //| Variable Begin                                                   |

   //+------------------------------------------------------------------+



double signalup=iCustom(Symbol(),0,"íôîðìàöèÿòà",0,1);

double signaldown=iCustom(Symbol(),0,"íôîðìàöèÿòà",1,1);



 

   //+------------------------------------------------------------------+

   //| Variable End                                                     |

   //+------------------------------------------------------------------+



   //Check position

   bool IsTrade = False;



   for (int i = 0; i < Total; i ++) {

      OrderSelect(i, SELECT_BY_POS, MODE_TRADES);

      if(OrderType() <= OP_SELL &&  OrderSymbol() == Symbol()) {

         IsTrade = True;

         if(OrderType() == OP_BUY) {

            //Close



            //+------------------------------------------------------------------+

            //| Signal Begin(Exit Buy)                                           |

            //+------------------------------------------------------------------+



if (NewBar()) Order = SIGNAL_CLOSEBUY;



            //+------------------------------------------------------------------+

            //| Signal End(Exit Buy)                                             |

            //+------------------------------------------------------------------+



            if (Order == SIGNAL_CLOSEBUY && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {

               OrderClose(OrderTicket(), OrderLots(), Bid, Slippage, MediumSeaGreen);

               if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Bid, Digits) + " Close Buy");

               if (!EachTickMode) BarCount = Bars;

               IsTrade = False;

               continue;

            }

            //Trailing stop

            if(UseTrailingStop && TrailingStop > 0) {                 

               if(Bid - OrderOpenPrice() > Point * TrailingStop) {

                  if(OrderStopLoss() < Bid - Point * TrailingStop) {

                     OrderModify(OrderTicket(), OrderOpenPrice(), Bid - Point * TrailingStop, OrderTakeProfit(), 0, MediumSeaGreen);

                     if (!EachTickMode) BarCount = Bars;

                     continue;

                  }

               }

            }

         } else {

            //Close



            //+------------------------------------------------------------------+

            //| Signal Begin(Exit Sell)                                          |

            //+------------------------------------------------------------------+



   if (NewBar()) Order = SIGNAL_CLOSESELL;               



            //+------------------------------------------------------------------+

            //| Signal End(Exit Sell)                                            |

            //+------------------------------------------------------------------+



            if (Order == SIGNAL_CLOSESELL && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {

               OrderClose(OrderTicket(), OrderLots(), Ask, Slippage, DarkOrange);

               if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Ask, Digits) + " Close Sell");

               if (!EachTickMode) BarCount = Bars;

               IsTrade = False;

               continue;

            }

            //Trailing stop

            if(UseTrailingStop && TrailingStop > 0) {                 

               if((OrderOpenPrice() - Ask) > (Point * TrailingStop)) {

                  if((OrderStopLoss() > (Ask + Point * TrailingStop)) || (OrderStopLoss() == 0)) {

                     OrderModify(OrderTicket(), OrderOpenPrice(), Ask + Point * TrailingStop, OrderTakeProfit(), 0, DarkOrange);

                     if (!EachTickMode) BarCount = Bars;

                     continue;

                  }

               }

            }

         }

      }

   }



   //+------------------------------------------------------------------+

   //| Signal Begin(Entry)                                              | 

   //+------------------------------------------------------------------+



 //if (timeprev!=Time[0]){

 //    timeprev = Time[0];

    

  if (signalup!=EMPTY_VALUE&&signalup!=0)   

      {

      Order = SIGNAL_BUY;

      }



  if (signaldown!=EMPTY_VALUE&&signaldown!=0){ 

      Order = SIGNAL_SELL;

      }

//     }

   //+------------------------------------------------------------------+

   //| Signal End                                                       |

   //+------------------------------------------------------------------+



   //Buy

   if (Order == SIGNAL_BUY && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {

      if(!IsTrade) {

         //Check free margin

         if (AccountFreeMargin() < (100 * Lots)) {

            Print("We have no money. Free Margin = ", AccountFreeMargin());

            return(0);

         }



         if (UseStopLoss) StopLossLevel = Ask - StopLoss * Point; else StopLossLevel = 0.0;

         if (UseTakeProfit) TakeProfitLevel = Ask + TakeProfit * Point; else TakeProfitLevel = 0.0;



         Ticket = OrderSend(Symbol(), OP_BUY, Lots, Ask, Slippage, StopLossLevel, TakeProfitLevel, "Buy(#" + MagicNumber + ")", MagicNumber, 0, DodgerBlue);

  

         if(Ticket > 0) {

            if (OrderSelect(Ticket, SELECT_BY_TICKET, MODE_TRADES)) {

				Print("BUY order opened : ", OrderOpenPrice());

                if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Ask, Digits) + " Open Buy");

			} else {

				Print("Error opening BUY order : ", GetLastError());

			}

         }

         if (EachTickMode) TickCheck = True;

         if (!EachTickMode) BarCount = Bars;

         return(0);

      }

   }



   //Sell

   if (Order == SIGNAL_SELL && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {

      if(!IsTrade) {

         //Check free margin

         if (AccountFreeMargin() < (100 * Lots)) {

            Print("We have no money. Free Margin = ", AccountFreeMargin());

            return(0);

         }



         if (UseStopLoss) StopLossLevel = Bid + StopLoss * Point; else StopLossLevel = 0.0;

         if (UseTakeProfit) TakeProfitLevel = Bid - TakeProfit * Point; else TakeProfitLevel = 0.0;



         Ticket = OrderSend(Symbol(), OP_SELL, Lots, Bid, Slippage, StopLossLevel, TakeProfitLevel, "Sell(#" + MagicNumber + ")", MagicNumber, 0, DeepPink);

     

        if(Ticket > 0) {

            if (OrderSelect(Ticket, SELECT_BY_TICKET, MODE_TRADES)) {

				Print("SELL order opened : ", OrderOpenPrice());

                if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Bid, Digits) + " Open Sell");

			} else {

				Print("Error opening SELL order : ", GetLastError());

			}

         }

         if (EachTickMode) TickCheck = True;

         if (!EachTickMode) BarCount = Bars;

         return(0);

      }

   }



   if (!EachTickMode) BarCount = Bars;



   return(0);

}

//+------------------------------------------------------------------+

    

//---- Check New Bar



bool NewBar()

{

   static datetime Time.PrevBar;

   bool PrevBar = ( Time.PrevBar < Time[0]);





   if(Time.PrevBar < Time[0])

   {

      Time.PrevBar = Time[0];

      return(true);

   }

   else

   return(false);

  

}

Can anyone help me out??