indicator wnt refresh on each new bar

New comment
 

I need help with an indicator I found in the metatrader library that works really well signalling pullbacks with the trend (I just ignore the false ones counter trend) but it doesnt test automatically on each bar close. I need to go chart by chart and switch out of that timeframe (5 min, 15 min etc..) and back to the timeframe I watch to see if a new red or green dot has appeared. Also it's in Russian except for the actual code.

Can someone fix the refresh part so it automatically appears on the bar close if applicable and most important, please post an explanation of what steps this indicator goes thru to test each bar--in other words, how it does work.

Thanks. 

//+------------------------------------------------------------------+

//|                                                     Beginner.mq4 |

//|                                                 Copyright © 2007 |

//+------------------------------------------------------------------+

#property copyright "Copyright © 2007, Heaven"

#property link      "beginner.com"

//----

#property indicator_chart_window

#property indicator_buffers 2

#property indicator_color1 Lime

#property indicator_color2 Red

#define  SH_BUY   1

#define  SH_SELL  -1

//---- Âõîäíûå ïàðàìåòðû

extern bool SoundON=true;

extern int     AllBars=0;//Äëÿ ñêîëüêè áàðîâ ñ÷èòàòü. 0 - äëÿ âñåõ.

extern int     Otstup=30;//Îòñòóï.

extern double  Per=9;//Ïåðèîä. //Per=period

//----

int            SH,NB,i,UD;

double         R,SHMax,SHMin;

double         BufD[];

double         BufU[];

int flagval1=0;

int flagval2=0;

//+------------------------------------------------------------------+

//| Ôóíêöèÿ èíèöèàëèçàöèè                                            |

//+------------------------------------------------------------------+

int init()

  {

   // NB çàïèñûâàåì êîëè÷åñòâî áàðîâ äëÿ êîòîðûõ ñ÷èòàåì èíäèêàòîð

   if (Bars<AllBars+Per || AllBars==0) NB=Bars-Per; else NB=AllBars;

   IndicatorBuffers(2);

   IndicatorShortName("SHI_SilverTrendSig");

   SetIndexStyle(0,DRAW_ARROW,0,1);

   SetIndexStyle(1,DRAW_ARROW,0,1);

   SetIndexArrow(0,159);

   SetIndexArrow(1,159);

   SetIndexBuffer(0,BufU);

   SetIndexBuffer(1,BufD);

   SetIndexDrawBegin(0,Bars-NB);//Èíäèêàòîð áóäåòîòîáðàæàòüñÿ òîëüêî äëÿ NB áàðîâ

   SetIndexDrawBegin(1,Bars-NB);

   ArrayInitialize(BufD,0.0);//Çàáü¸ì îáà áóôåðà íîëèêàìè. Èíà÷å áóäåò ìóñîð ïðè ñìåíå òàéìôðåéìà.

   ArrayInitialize(BufU,0.0);

   return(0);

  }

//+------------------------------------------------------------------+

//| Ôóíêöèÿ äåèíèöèàëèçàöèè                                          |

//+------------------------------------------------------------------+

int deinit()

  {

   return(0);

  }

//+------------------------------------------------------------------+

//| Ñîáñíà èíäèêàòîð                                                 |

//+------------------------------------------------------------------+

int start()

  {

   int CB=IndicatorCounted();

   /* Òóò âîò òà ñàìàÿ îïòèìèçàöèîííàÿ ôèøêà.  ÿçûê ââåäåíà ôóíêöèÿ, êîòîðàÿ âîçâðàùàåò êîëè÷åñòâî

   ïîñ÷èòàííûõ áàðîâ, ïðè÷¸ì î÷åíü õèòðî. Ïðè ïåðâîì âûçîâå èíäèêàòîðà ýòî 0, âñ¸ ïîíÿòíî, åù¸ íè÷åãî

   íå ñ÷èòàëîñü, à çàòåì âûäà¸ò êîëè÷åñòâî îáñ÷èòàííûõ áàðîâ ìèíóñ îäèí. Ò.å. åñëè âñåãî áàðîâ 100,

   òî ôóíêöèÿ âåðí¸ò 99. ß ââ¸ë òàêîé êîä, âûøå ó ìåíÿ îïðåäåëÿëàñü NB - êîë-âî áàðîâ ïîäëåæàùèõ

   îáñ÷¸òó.  ïðèíöèïå ýòîò ïàðàìåòð ìîæíî è âûêèíóòü, îäíàêî äëÿ òåõ êòî â òàíêå (I80286) ìîæíî

   è îñòàâèòü. Òàê âîò, çäåñü, ïðè ïåðâîì âûçîâå NB îñòà¸òñÿ ïðåæíåé, à ïðè ïîñëåäóþùèõ óìåíüøàåòñÿ

   äî ïîñëåäíåãî áàðà, ò.å. 1 èëè 2, íó èëè ñêîëüêî òàì îñòàëîñü ïîñ÷èòàòü*/

   if(CBBars-CB) NB=Bars-CB;

   for(SH=1;SH<NB;SH++)//Ïðî÷¸ñûâàåì ãðàôèê îò 1 äî NB

     {

      for(R=0,i=SH;i<SH+10;i++) {R+=(10+SH-i)*(High-Low);}      R/=55;

//----

      SHMax=High[Highest(NULL,0,MODE_HIGH,Per,SH)];

      SHMin=Low[Lowest(NULL,0,MODE_LOW,Per,SH)];

      if (Close[SH]<SHMin+(SHMax-SHMin)*Otstup/100 && UD!=SH_SELL)

        {

         // Pop an Alert

         if (SH==1 && flagval1==0)

           {

            flagval1=1;

            flagval2=0;

   if (SoundON) Alert("BUY signal at Ask=",Ask,"\n Bid=",Bid,"\n Time=",TimeToStr(CurTime(),TIME_DATE)," ",TimeHour(CurTime()),":",TimeMinute(CurTime()),"\n Symbol=",Symbol()," Period=",Period());

           }

      BufU[SH]=Low[SH]-R*0.5; UD=SH_SELL;

        }

      if (Close[SH]>SHMax-(SHMax-SHMin)*Otstup/100 && UD!=SH_BUY)

        {

         // pop an Alert

         if (SH==1 && flagval2==0)

           {

            flagval2=1;

            flagval1=0;

     if (SoundON) Alert("SELL signal at Ask=",Ask,"\n Bid=",Bid,"\n Date=",TimeToStr(CurTime(),TIME_DATE)," ",TimeHour(CurTime()),":",TimeMinute(CurTime()),"\n Symbol=",Symbol()," Period=",Period());

           }

         BufD[SH]=High[SH]+R*0.5; UD=SH_BUY;

        }

     }

   return(0);

  }

//+---------------------------------------------

New comment
Reason: