help me with the code - page 4
You are missing trading opportunities:
- Free trading apps
- Over 8,000 signals for copying
- Economic news for exploring financial markets
Registration
Log in
You agree to website policy and terms of use
If you do not have an account, please register
Ohh sorry i just add comments to explain ill remove it.
here is the code
and i also made some corrections and getting only one error '=='different types in comparison @125,24
here is the code
and i also made some corrections and getting only one error '=='different types in comparison @125,24
It's clear you don't understand what a string is . . . please do some reading and learn, you are wasting your time otherwise.
How can this make sense ?
how can a bool, err_mf_buy be equal to a string ?
How does this make sense ?
the string mf_sellsp will never be equal to Sell_ans how is a sting less than another string ? is apple <= orange ?
//+------------------------------------------------------------------+ //| every tick20.mq4 | //| mohsin mewati | //| | //+------------------------------------------------------------------+ #property copyright "mohsin mewati" #property link "" //+------------------------------------------------------------------+ //| expert initialization function | //+------------------------------------------------------------------+ int init() { //---- int order_open_time_buy =0;//intiger to save buy open Time int order_open_time_sell =0;//intiger to save sell open Time bool err_close_all_orders =0;//bolean to save get last error for close all opened orders code bool err_sell=0; bool err_buy=0; bool err_selection_buy=0; bool err_selection_sell=0; bool buy_modified=0; bool sell_modified=0; double mf_buy=0; double mf_sell=0; int buy_trail=0; int err_trail_buy=0; int err_modify_sell=0; int buy_selection=0; bool buy_open_price=0; int sell_selection=0; //---- return(0); } //+------------------------------------------------------------------+ //| expert start function | //+------------------------------------------------------------------+ //---- int start() { bool err_buy; int buy_ticket; bool err_sell; int sell_ticket; bool err_selection_buy; int buy_selection; double buy_open_price; bool err_selection_sell; int sell_selection; bool err_mf_buy; bool srr_mf_sell; bool err_mf_sell; bool err_trail_buy; bool err_modify_sell; bool buy_modified; bool err_trail_sell; bool err_modify_buy; int buy_trail=0; int sell_trail=0; string buy; string sell; int bp=20; int sp=20; double buy_ans; double sell_ans; double slbuy; double slsell; double tp_sell; double tp_buy; int i=1; double tpbuy; double tpsell; //coding starts while(err_buy==0){//for loop started to execute a buy Order buy_ticket=OrderSend("GBPUSD",OP_BUY,1,Ask,3,Ask+20*Point,0,Green); //code to execute a buy (buy order placed without SL but with a TP of 20 pips err_buy=GetLastError();//code to check either buy is executed or not? }//for loop end while(err_sell==0){//for loop to place a sell order sell_ticket = OrderSend("GBPUSD",OP_SELL,1,Ask,3,Ask-20*Point,0,Red);//code to place a sell ,order placed without SL but with a TP of 20 pips err_sell=GetLastError();//code to check either sell is placed or not? }//for loop ends Alert("buy/sell executed"); //__________________________________________________________________________________________________________________________________ while(err_selection_buy==0){// for loop start to selection of first executed order for further procedure buy_selection=OrderSelect(buy_ticket,SELECT_BY_TICKET);//order select and stored in intiger err_selection_buy=GetLastError();//code to check eithet order is selected or not }//for loop ends buy_open_price=OrderOpenPrice();//taking open price for the first selected order buy_ans=buy_open_price; tpbuy=buy_ans+0.00050; while(err_selection_sell==0){// for loop start to selection of second executed order for further procedure sell_selection=OrderSelect(sell_ticket,SELECT_BY_TICKET);//order select and stored in intiger err_selection_sell=GetLastError();//code to check eithet order is selected or not }//for loop ends double sell_open_price=OrderOpenPrice();//taking open price for the second selected order sell_ans=sell_open_price; tpsell=sell_ans-0.00050; while(buy_trail==0 && sell_trail==0){// while loop started to check if thow of them or one is true while (err_mf_buy==0 && err_mf_sell==0){//while loop start to take price quote every time for buy and sell double mf_buy=MarketInfo("GBPUSD",MODE_POINT);//code to store markeet info in integer mf_buy err_mf_buy=GetLastError();//code to confirm the previous line of code executed? double mf_sell=MarketInfo("GBPUSD",MODE_POINT);//code to store markeet info in integer mf_sell err_mf_sell=GetLastError();//code to confirm the previous line of code executed? } if (mf_buy==slbuy){ buy="closed";} else{ if( mf_sell==slsell){ sell="closed";} else{ i++; } } if(mf_buy-bp == buy_ans && buy=="open"){//if condition to compare if current markeet quote which stored in mf_buy is 20 times greater than the open price of buy Order? while(err_trail_buy==0){//if above condition true for loop started to start trailing on buy order. OrderModify(buy_ticket,buy_open_price,slbuy,tpbuy,0,Blue); bp=(bp+5); err_trail_buy=GetLastError();//code to confirm the previous line of code executed? } if(bp>=30){ tp_sell=0.00005; while(err_modify_sell==0){//if buy is in profit for 20 pips and trailing stop started on it i want my sell to modify for take profit for just 5 pips. OrderModify(sell_ticket,sell_open_price,slsell,tpsell,0,Red); err_modify_sell=GetLastError();//code to confirm the previous line of code executed? buy_trail=1;//intiger use to remember that the buy was in profit and all the cooding associated with it was executed there is no need to check . } } else{ i++; } if (mf_sell+sp<=sell_ans && sell=="open"){//another logical test to check if buy was not in 20 pips if our sell is in 20 pips profit if so then in the next for loop statrted while(err_trail_sell==0){//for loop start to modify sell for trail OrderModify(sell_ticket,sell_open_price,slsell,tpsell,0,Red); sp=(sp+5); err_trail_sell=GetLastError();//code to confirm the previous line of code executed? } if(sp>=30){ tp_buy=0.00005; while(err_modify_buy==0){//if our sell is in 20 pips profit and trailing executed on it while loop start to modify buy for tp for just 5 pips OrderModify(buy_ticket,buy_open_price,slbuy,tpbuy,0,Blue); err_modify_buy=GetLastError();//code to confirm the previous line of code executed? sell_trail=1;//intiger use to remember that the sell was in profit and all the cooding associated with it was executed there is no need to check . } } else{ i++; } } } } double ab=AccountBalance(); //---- return(0); } //+------------------------------------------------------------------+ //+------------------------------------------------------------------+ //| expert deinitialization function | //+------------------------------------------------------------------+ int deinit() { //---- //---- return(0); }now meta editor ask about predefined variables
Is Buy declared ?
Is Sell_trail declared ?
Is Sell_ans declared ?
Is Sell declared ?
sp is an int . . how does this make sense ?
sp = "(sp+5)";yes i made these case sensitive corrections and currently im backtesting the stratigy thanks A LOT