Stochastic %D Color Change

 

Hi,
I tried to modify the stochastic codes to display rising and falling color for %D, but I did not get the required result. Attached is my codes. Can someone please help to advise what was wrong with the codes? Many thanks.

//+------------------------------------------------------------------+
//|                                                   Stochastic.mq4 |
//|                      Copyright © 2004, MetaQuotes Software Corp. |
//|                                       http://www.metaquotes.net/ |
//+------------------------------------------------------------------+
#property copyright "Copyright © 2004, MetaQuotes Software Corp."
#property link      "http://www.metaquotes.net/"

#property indicator_separate_window
#property indicator_minimum 0
#property indicator_maximum 100
#property indicator_buffers 7
#property indicator_color1 LightSeaGreen
#property indicator_color2 Red
#property indicator_color3 Green
#property indicator_color4 Yellow
#property indicator_color5 Orange
//---- input parameters
extern int KPeriod=10;
extern int DPeriod=3;
extern int Slowing=3;
//---- buffers
double MainBuffer[];
double Signal_Down_Buffer[];
double Signal_Up_Buffer[];
double Signal_Flat_Buffer[];
double SignalBuffer[];
double HighesBuffer[];
double LowesBuffer[];
//----
int draw_begin1=0;
int draw_begin2=0;
//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
int init()
  {
   string short_name;
//---- 2 additional buffers are used for counting.
   IndicatorBuffers(7);
   SetIndexBuffer(5, HighesBuffer);
   SetIndexBuffer(6, LowesBuffer);
//---- indicator lines

   SetIndexBuffer(0, MainBuffer); 
   SetIndexBuffer(1, Signal_Down_Buffer);
   SetIndexBuffer(2, Signal_Up_Buffer);
   SetIndexBuffer(3, Signal_Flat_Buffer);
   SetIndexBuffer(4, SignalBuffer);
   SetIndexStyle(0,DRAW_LINE);
   SetIndexStyle(1,DRAW_LINE);
   SetIndexStyle(2,DRAW_LINE);
   SetIndexStyle(3,DRAW_LINE);
   SetIndexStyle(4,DRAW_LINE);
   SetIndexStyle(5,DRAW_NONE); 
   SetIndexStyle(6,DRAW_NONE);
//---- name for DataWindow and indicator subwindow label
   short_name="Sto("+KPeriod+","+DPeriod+","+Slowing+")";
   IndicatorShortName(short_name);
   SetIndexLabel(0,short_name);
   SetIndexLabel(1,"Signal");
//----
   draw_begin1=KPeriod+Slowing;
   draw_begin2=draw_begin1+DPeriod;
   SetIndexDrawBegin(0,draw_begin1);
   SetIndexDrawBegin(1,draw_begin2);
   SetIndexDrawBegin(2,draw_begin2);
   SetIndexDrawBegin(3,draw_begin2);
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| Stochastic oscillator                                            |
//+------------------------------------------------------------------+
int start()
  {
   int    i,k;
   int    counted_bars=IndicatorCounted();
   double price,Signal_cur,Signal_pre;
//----
   if(Bars<=draw_begin2) return(0);
//---- initial zero
   if(counted_bars<1)
     {
      for(i=1;i<=draw_begin1;i++) MainBuffer[Bars-i]=0;
      for(i=1;i<=draw_begin2;i++) SignalBuffer[Bars-i]=0;
      for(i=1;i<=draw_begin2;i++) Signal_Up_Buffer[Bars-i]=0;
      for(i=1;i<=draw_begin2;i++) Signal_Down_Buffer[Bars-i]=0;
      for(i=1;i<=draw_begin2;i++) Signal_Flat_Buffer[Bars-i]=0;
     }
//---- minimums counting
   i=Bars-KPeriod;
   if(counted_bars>KPeriod) i=Bars-counted_bars-1;
   while(i>=0)
     {
      double min=1000000;
      k=i+KPeriod-1;
      while(k>=i)
        {
         price=Low[k];
         if(min>price) min=price;
         k--;
        }
      LowesBuffer[i]=min;
      i--;
     }
//---- maximums counting
   i=Bars-KPeriod;
   if(counted_bars>KPeriod) i=Bars-counted_bars-1;
   while(i>=0)
     {
      double max=-1000000;
      k=i+KPeriod-1;
      while(k>=i)
        {
         price=High[k];
         if(max<price) max=price;
         k--;
        }
      HighesBuffer[i]=max;
      i--;
     }
//---- %K line
   i=Bars-draw_begin1;
   if(counted_bars>draw_begin1) i=Bars-counted_bars-1;
   while(i>=0)
     {
      double sumlow=0.0;
      double sumhigh=0.0;
      for(k=(i+Slowing-1);k>=i;k--)
        {
         sumlow+=Close[k]-LowesBuffer[k];
         sumhigh+=HighesBuffer[k]-LowesBuffer[k];
        }
      if(sumhigh==0.0) MainBuffer[i]=100.0;
      else MainBuffer[i]=sumlow/sumhigh*100;
      i--;
     }
//---- last counted bar will be recounted
   if(counted_bars>0) counted_bars--;
   int limit=Bars-counted_bars;
//---- signal line is simple movimg average
   for(i=0; i<limit; i++)
   {
      Signal_cur=iMAOnArray(MainBuffer,Bars,DPeriod,0,MODE_SMA,i);
      Signal_pre=iMAOnArray(MainBuffer,Bars,DPeriod,0,MODE_SMA,i+1);
      SignalBuffer[i]=Signal_cur;
      Signal_Up_Buffer[i]=Signal_cur;
      Signal_Flat_Buffer[i]=Signal_cur;
      Signal_Down_Buffer[i]=Signal_cur;
      if (Signal_cur < Signal_pre) { Signal_Down_Buffer[i]=EMPTY_VALUE; }
      else if (Signal_cur > Signal_pre) { Signal_Flat_Buffer[i]=EMPTY_VALUE; }
            else { Signal_Up_Buffer[i]=EMPTY_VALUE;Signal_Down_Buffer[i]=EMPTY_VALUE; }
   }  
      
//----
   return(0);
  }
//+------------------------------------------------------------------+
Reason: