Could someone please review for me?

[[Deleted]]

else

bool found = false;

for(int k=OrdersHistoryTotal()-1;k>=0;k--)

{

if((OrderSelect(k,SELECT_BY_POS,MODE_HISTORY))&&(OrderMagicNumber()==MagicNumber150000))

{

found = true;

break;

}

} THIS PIECE ABOVE BASICALLY LOOKS TO SEE IF THIS ORDER HAS BEEN PLACED AND CLOSED(MOVED TO HISTORY).

if(found == false)

{

for(k=OrdersTotal()-1;k>=0;k--)

{

if((OrderSelect(k,SELECT_BY_POS,MODE_TRADES))&&(OrderMagicNumber()==MagicNumber150001)&& OrderType()==OP_SELL || OrderType()==OP_BUY)

{

if(OrderProfit() >= 50)

{

if((OrderSelect(k,SELECT_BY_POS,MODE_TRADES))&&(OrderMagicNumber()==MagicNumber150000))

{

OrderClose(OrderTicket());

}

if((OrderSelect(k,SELECT_BY_POS,MODE_TRADES))&&(OrderMagicNumber()==MagicNumber150001))

{

OrderClose(OrderTicket());

}

if((OrderSelect(k,SELECT_BY_POS,MODE_TRADES))&&(OrderMagicNumber()==MagicNumber150002))

{

OrderDelete(OrderTicket());

}

}

}

THIS PIECE ABOVE LOOKS FOR MY SECOND ORDER TO BE PLACED(HENCE ORDERTYPE OF SELL OR BUY, NOT LIMIT OR STOP TYPE). IF SO, I WANT IT TO EVALUATE THE ORDERPROFIT OF THE SECOND ORDER(MAGICNUMBER 150001) AND IF A VALUE, CLOSE OPEN ORDERS AND DELETE REMAINING PENDING ORDER.

if((OrderSelect(k,SELECT_BY_POS,MODE_TRADES))&&(OrderMagicNumber()==MagicNumber150002)&& OrderType()==OP_SELL || OrderType()==OP_BUY)

{

if(OrderProfit() >= 120)

{

if((OrderSelect(k,SELECT_BY_POS,MODE_TRADES))&&(OrderMagicNumber()==MagicNumber150002))

{

OrderClose(OrderTicket());

}

if((OrderSelect(k,SELECT_BY_POS,MODE_TRADES))&&(OrderMagicNumber()==MagicNumber150001))

{

OrderClose(OrderTicket());

}

if((OrderSelect(k,SELECT_BY_POS,MODE_TRADES))&&(OrderMagicNumber()==MagicNumber150000))

{

OrderClose(OrderTicket());

}

}

}

}

}

THIS FINAL PIECE LOOKS TO SEE IF MY THIRD ORDER HAS BEEN PLACED. IF SO, THEN IT EVALUATES THAT ORDER'S PROFIT AND ONCE IT HITS 120, WILL CLOSE ALL OPEN ORDERS(MAGICNUMBERS 150000,150001, AND 150002).

Any help would be truly appreciated! I just need to make sure I have the right syntax and that this will flow with no issues. Thank you forum-this is a great tool for us beginners to MQL!!! Daniel

[Magnus Meseck]

Do you have a problem with the code?

I did'nt try to compile it but looks good. But just a little hint:

if((Orderselect(...))&&(Ordermagicnumber()==Magicnumber150002))  // this can also be written as....

if(Orderselect(...)==true && Ordermagicnumber()==Magicnumber15002)

So you don't need to use brackets within the if-operator condition.

Didn't look over it too closely though...