Indicator issues with highlighting a certain time frame...EX: start 22:00 end 02:00

New comment
 

Hello,

I am fairly new to programming and am trying to play around with an indicator that i got.


What is supposed to do is highlight between hours 22:00 and 02:00 (following day) but instead it highlights everything except for the times i want highlighted.


Any ideas?


thanks!

 
Show your code
 

Oh right that would help :)


//+------------------------------------------------------------------+





#property indicator_chart_window

//------- -------------------------------
extern int NumberOfDays = 1; // Backtest Days
extern string Begin_1 = "01:00";
extern string End_1 = "22:00";
extern color Color_1 = DarkBlue;
extern string Begin_2 = "00:00";
extern string End_2 = "00:00";
extern color Color_2 = Brown;
extern bool HighRange = False;


//+------------------------------------------------------------------+
//| Custom indicator initialization function |
//+------------------------------------------------------------------+
void init() {
DeleteObjects();
for (int i=0; i<NumberOfDays; i++) {
CreateObjects("PWT1"+i, Color_1);
CreateObjects("PWT2"+i, Color_2);
}
Comment("");
}

//+------------------------------------------------------------------+
//| Custor indicator deinitialization function |
//+------------------------------------------------------------------+
void deinit() {
DeleteObjects();
Comment("");
}

//+------------------------------------------------------------------+
|
//+------------------------------------------------------------------+
void CreateObjects(string no, color cl) {
ObjectCreate(no, OBJ_RECTANGLE, 0, 0,0, 0,0);
ObjectSet(no, OBJPROP_STYLE, STYLE_SOLID);
ObjectSet(no, OBJPROP_COLOR, cl);
ObjectSet(no, OBJPROP_BACK, True);
}

//+------------------------------------------------------------------+
//|
//+------------------------------------------------------------------+
void DeleteObjects() {
for (int i=0; i<NumberOfDays; i++) {
ObjectDelete("PWT1"+i);
ObjectDelete("PWT2"+i);
}
}

//+------------------------------------------------------------------+
//| Custom indicator iteration function |
//+------------------------------------------------------------------+
void start() {
datetime dt=CurTime();

for (int i=0; i<NumberOfDays; i++) {
DrawObjects(dt, "PWT1"+i, Begin_1, End_1);
DrawObjects(dt, "PWT2"+i, Begin_2, End_2);
dt=decDateTradeDay(dt);
while (TimeDayOfWeek(dt)>5) dt=decDateTradeDay(dt);
}
}

//+------------------------------------------------------------------+

void DrawObjects(datetime dt, string no, string tb, string te) {
datetime t1, t2;
double p1, p2;
int b1, b2;

t1=StrToTime(TimeToStr(dt, TIME_DATE)+" "+tb);
t2=StrToTime(TimeToStr(dt, TIME_DATE)+" "+te);
b1=iBarShift(NULL, 0, t1);
b2=iBarShift(NULL, 0, t2);
p1=High[Highest(NULL, 0, MODE_HIGH, b1-b2, b2)];
p2=Low [Lowest (NULL, 0, MODE_LOW, b1-b2, b2)];
if (!HighRange) {p1=0; p2=2*p2;}
ObjectSet(no, OBJPROP_TIME1, t1);
ObjectSet(no, OBJPROP_PRICE1, p1);
ObjectSet(no, OBJPROP_TIME2, t2);
ObjectSet(no, OBJPROP_PRICE2, p2);
}

//+------------------------------------------------------------------+

datetime decDateTradeDay (datetime dt) {
int ty=TimeYear(dt);
int tm=TimeMonth(dt);
int td=TimeDay(dt);
int th=TimeHour(dt);
int ti=TimeMinute(dt);

td--;
if (td==0) {
tm--;
if (tm==0) {
ty--;
tm=12;
}
if (tm==1 || tm==3 || tm==5 || tm==7 || tm==8 || tm==10 || tm==12) td=31;
if (tm==2) if (MathMod(ty, 4)==0) td=29; else td=28;
if (tm==4 || tm==6 || tm==9 || tm==11) td=30;
}
return(StrToTime(ty+"."+tm+"."+td+" "+th+":"+ti));
}
//+------------------------------------------------------------------+
 

What is supposed to do is highlight between hours 22:00 and 02:00 (following day) but instead it highlights everything except for the times i want highlighted.

.
extern string Begin_1 = "01:00";
extern string End_1 = "22:00";
.

Looks like it is doing what you tell it.. start the object at 1am and end at 10pm

your code certainly looks complex for the task.

 
phy:

What is supposed to do is highlight between hours 22:00 and 02:00 (following day) but instead it highlights everything except for the times i want highlighted.

.
extern string Begin_1 = "01:00";
extern string End_1 = "22:00";
.

Looks like it is doing what you tell it.. start the object at 1am and end at 10pm

your code certainly looks complex for the task.

if i try to go 22:00 to 01:00 it still highlights same timeframe i want 10pm to 1am (the following day) to be highlighted...might go back to drawing board for this one :P

New comment
Reason: