A function to loop through open positions and make pairs of arrays of tickets then close each pair of array if greater than target profit

MQL4 Esperti

Lavoro terminato

Tempo di esecuzione 6 minuti
Feedback del cliente
very good!
Feedback del dipendente
Great customer! Thank you for the order!

Specifiche

This is for an MT4 EA.

I need a function to loop through all open positions and store them in arrays based on price levels.
Then from these arrays (i.e. @ price 1760 there are open orders and @ price 1770 there are open orders and so on).
I want to calculate the ongoing profit of pairs of 2 arrays (i.e. sell array i with buy array i+1     AND    buy array i with sell array i-1).
And if profit is greater than target, close orders of these pairs of arrays. Each array may contain more than 1 ticket and can go up to x tickets, and the function will close the arrays only if the pairs contain minimally an array in each level.
The function will loop through all the arrays crawling from initial price up and down.
An optional function can also close the pairs of arrays if the total tickets in these pairs are x (can be input).
Code is already written, but i currently have problem with :

void CalculateAndCloseOrderGroupsForBuyAndSell() {
    // Loop from the initial_index down to 1 (since i-1 sell for i=0 doesn't exist)
    for (int i = initial_index; i > 0; i--) {
        double totalProfit = 0.0;
        
        if (buyTicketCounts[i] > 0 && sellTicketCounts[i-1] > 0){
           // Calculate profit for all buy tickets at index i
           for (int j = 0; j < buyTicketCounts[i]; j++) {
               int ticket = buyTickets[i][j];
               totalProfit += ComputeProfitForOrder(ticket);
           }
   
           // Calculate profit for all sell tickets at index i-1
           for (int j = 0; j < sellTicketCounts[i - 1]; j++) {
               int ticket = sellTickets[i - 1][j];
               totalProfit += ComputeProfitForOrder(ticket);
           }
          }

        // If the combined profit meets or exceeds the target, close the tickets and remove them from arrays
        if (totalProfit >= profit_target) {
            // Close and remove buy tickets at index i
            for (int j = buyTicketCounts[i] - 1; j >= 0; j--) {
                CloseOrder(buyTickets[i][j]);
                // Shift tickets to remove the closed ticket from the array
                for (int k = j; k < buyTicketCounts[i] - 1; k++) {
                    buyTickets[i][k] = buyTickets[i][k + 1];
                }
                buyTicketCounts[i]--;
            }

            // Close and remove sell tickets at index i-1
            for (int j = sellTicketCounts[i - 1] - 1; j >= 0; j--) {
                CloseOrder(sellTickets[i - 1][j]);
                // Shift tickets to remove the closed ticket from the array
                for (int k = j; k < sellTicketCounts[i - 1] - 1; k++) {
                    sellTickets[i - 1][k] = sellTickets[i - 1][k + 1];
                }
                sellTicketCounts[i - 1]--;
            }

            Print("Closed and removed orders for buy zone ", i, " and sell zone ", i - 1, " with total profit: ", totalProfit);
        }
    }
}


it always gives me "out of array" error. I will give the whole set of code. the focus is to fix this part to overcome the "out of array" issue/ error.


Thank you.




Con risposta

1
Sviluppatore 1
Valutazioni
(100)
Progetti
125
23%
Arbitraggio
12
0% / 75%
In ritardo
22
18%
Gratuito
2
Sviluppatore 2
Valutazioni
(72)
Progetti
80
10%
Arbitraggio
38
8% / 58%
In ritardo
6
8%
Gratuito
3
Sviluppatore 3
Valutazioni
(53)
Progetti
91
52%
Arbitraggio
2
0% / 50%
In ritardo
1
1%
Gratuito
4
Sviluppatore 4
Valutazioni
(23)
Progetti
45
20%
Arbitraggio
25
28% / 48%
In ritardo
12
27%
Gratuito
5
Sviluppatore 5
Valutazioni
(67)
Progetti
97
35%
Arbitraggio
11
27% / 45%
In ritardo
13
13%
Gratuito
6
Sviluppatore 6
Valutazioni
(568)
Progetti
657
32%
Arbitraggio
41
41% / 46%
In ritardo
11
2%
Occupato
7
Sviluppatore 7
Valutazioni
(6)
Progetti
10
10%
Arbitraggio
9
0% / 89%
In ritardo
1
10%
Gratuito
8
Sviluppatore 8
Valutazioni
(69)
Progetti
146
34%
Arbitraggio
13
8% / 62%
In ritardo
26
18%
Gratuito
Pubblicati: 6 codici
9
Sviluppatore 9
Valutazioni
(568)
Progetti
641
41%
Arbitraggio
25
48% / 36%
In ritardo
46
7%
In elaborazione
Ordini simili
I need a professional MQL5 developer. BEFORE I SHARE ANY DETAILS: 1. You must sign a PERPETUAL NDA with no expiration date 2. NDA includes €100,000 penalty for any breach 3. I require full .mq5 source code ownership 4. Developer must have 500+ completed jobs, 4.9+ rating Budget: €1500 EUR Duration: 14 days Start your application with "RULER" to prove you read this
i have a simple strategy can you please create the automated forex ea to execute my trading strategy? i need custom ea for tradingview and mt4/mt5 correction: i need a tradingview indicator created that tells me when to buy or sell. and ea in mt4/mt5
Pip Scalper Bot 60+ USD
i want a trading bot that is aleast 98% sure,and cam also do scalping 99% correct using smart money concept, ICT, ALL technical analysis on it and also put risk management on it
It is very important, that your software can replicate the trade logic 1:1 as the original myfxbook statistic. You should have a professional software to analyze the trade logic. I tried it with ChatGPT and GROK and it doesnt worked at all. You need to have better tools for that job. If you can not do it to 99% same trade logic as the original statistic do not message me. Payment only after delivering the EA (Demo
Greetings I need MT5 developer that has expertise in developing a custom indicator for mt5 boom and crash based on my exact details and requirements which would be discuss later. Kindly bid for this project if it is something you can handle for me
I need a fully functional Expert Advisor (EA) for MetaTrader 5 focused on trading XAUUSD (Gold). The strategy should be based on fast scalping entries using indicators such as RSI, Moving Averages, or similar confirmation tools. The EA must include fixed risk management (1%–2% per trade), automatic lot calculation, and stop loss/take profit settings. It should be optimized for low spread conditions and quick market
Mt5 EA 50 - 69 USD
I am a private trader looking for a reliable EA that can generate steady daily profits of around $35 to $40 with proper risk management. My goal is to find or improve an EA strategy that can deliver consistent results, especially on Gold (XAUUSD). If you believe you can review the current EA or develop a better solution, I would be interested in working with you. However, I would need to verify the EA on a demo
Subject:currently have a working EA installed with 3 indicators, but it’s not profitable.What I need: A trader/developer with a proven indicator that can be converted/integrated into my existing EA. The indicator must show a pass rate of 80% or higher on backtest/forward test.Scope of work: Your indicator will be added to my existing EA and must work with the current strategy logic. I will first test the indicator’s
I would like to program a ninja trader strategy that involves a Cycle ID indicator. Can you take a look to see if you can program the indicator in a strategy? Let me know if you can do this
Hello, I have a Ctrader indicator with the source code, I was wondering if this possible to convert it to Quantower. Hello, I have a Ctrader indicator with the source code, I was wondering if tis possible to convert it to Quantower., i need an expert who can convert it perfectly

Informazioni sul progetto

Budget
30 - 45 USD