LW MA EA Entry/Exit help

[Deleted] 2010.11.25 18:39

Hello Everyone,

Can someone help me with this? I want it to enter/exit trades when the lw ma's cross. It works for a few trades at first then get a 402 error in the journal.

#define SIGNAL_NONE 0
#define SIGNAL_BUY 1
#define SIGNAL_SELL 2
#define SIGNAL_CLOSEBUY 3
#define SIGNAL_CLOSESELL 4

#property copyright "Expert Advisor Builder"
#property link "http://sufx.core.t3-ism.net/ExpertAdvisorBuilder/"
extern int breakeven = 15;
extern int addbreak = 0;
extern int MagicNumber = 120000;
extern int fastperiods = 1;
extern int slowperiods = 3;

extern bool SignalMail = False;
extern bool EachTickMode = True;
extern double Lots = 1.0;
extern int Slippage = 3;
extern bool UseStopLoss = False;
extern int StopLoss = 30;
extern bool UseTakeProfit = False;
extern int TakeProfit = 60;
extern bool UseTrailingStop = False;
extern int TrailingStop = 30;
extern bool UseHourTrade = False;
extern int FromHourTrade = 7;
extern int ToHourTrade = 22;

int BarCount;
int Current;
bool TickCheck = False;
//+------------------------------------------------------------------+
//| expert initialization function |
//+------------------------------------------------------------------+
int init() {
BarCount = Bars;

if (EachTickMode) Current = 0; else Current = 1;

return(0);
}
//+------------------------------------------------------------------+
//| expert deinitialization function |
//+------------------------------------------------------------------+
int deinit() {
return(0);
}
//+------------------------------------------------------------------+
//| expert start function |
//+------------------------------------------------------------------+
int start() {
if (UseHourTrade){
if (!(Hour()>=FromHourTrade && Hour()<=ToHourTrade)) {
Comment("Not time to trade yet!");
return(0);
} else Comment("");
}else Comment("");
int Order = SIGNAL_NONE;
int Total, Ticket;
double StopLossLevel, TakeProfitLevel;

if(breakeven != 0) activatebreakeven(MagicNumber);

//double fastma = iMA(NULL, 0, fastperiods, 0, MODE_LWMA, PRICE_LOW, 1);
//double slowma = iMA(NULL, 0, slowperiods, 0, MODE_LWMA, PRICE_CLOSE, 1);

if (EachTickMode && Bars != BarCount) TickCheck = False;
Total = OrdersTotal();
Order = SIGNAL_NONE;

//+------------------------------------------------------------------+
//| Variable Begin |
//+------------------------------------------------------------------+

double Buy1_1 = iMA(NULL, 0, fastperiods, 0, MODE_LWMA, PRICE_LOW, Current + 0);
double Buy1_2 = iMA(NULL, 0, slowperiods, 0, MODE_LWMA, PRICE_CLOSE, Current + 0);
double Buy2_1 = iMA(NULL, 0, fastperiods, 0, MODE_LWMA, PRICE_LOW, Current + 1);
double Buy2_2 = iMA(NULL, 0, slowperiods, 0, MODE_LWMA, PRICE_CLOSE, Current + 0);

double Sell1_1 = iMA(NULL, 0, fastperiods, 0, MODE_LWMA, PRICE_HIGH, Current + 0);
double Sell1_2 = iMA(NULL, 0, slowperiods, 0, MODE_LWMA, PRICE_CLOSE, Current + 0);
double Sell2_1 = iMA(NULL, 0, fastperiods, 0, MODE_LWMA, PRICE_HIGH, Current + 1);
double Sell2_2 = iMA(NULL, 0, slowperiods, 0, MODE_LWMA, PRICE_CLOSE, Current + 0);

double CloseBuy1_1 = iMA(NULL, 0, fastperiods, 0, MODE_LWMA, PRICE_HIGH, Current + 0);
double CloseBuy1_2 = iMA(NULL, 0, slowperiods, 0, MODE_LWMA, PRICE_CLOSE, Current + 0);

double CloseSell1_1 = iMA(NULL, 0, fastperiods, 0, MODE_LWMA, PRICE_LOW, Current + 0);
double CloseSell1_2 = iMA(NULL, 0, slowperiods, 0, MODE_LWMA, PRICE_CLOSE, Current + 0);

//+------------------------------------------------------------------+
//| Variable End |
//+------------------------------------------------------------------+

//Check position
bool IsTrade = False;

for (int i = 0; i < Total; i ++) {
OrderSelect(i, SELECT_BY_POS, MODE_TRADES);
if(OrderType() <= OP_SELL && OrderSymbol() == Symbol()) {
IsTrade = True;
if(OrderType() == OP_BUY) {
//Close

//+------------------------------------------------------------------+
//| Signal Begin(Exit Buy) |
//+------------------------------------------------------------------+

if (CloseBuy1_1 < CloseBuy1_2) Order = SIGNAL_CLOSEBUY;

//+------------------------------------------------------------------+
//| Signal End(Exit Buy) |
//+------------------------------------------------------------------+

if (Order == SIGNAL_CLOSEBUY && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
OrderClose(OrderTicket(), OrderLots(), Bid, Slippage, MediumSeaGreen);
if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Bid, Digits) + " Close Buy");
if (!EachTickMode) BarCount = Bars;
IsTrade = False;
continue;
}
//Trailing stop
if(UseTrailingStop && TrailingStop > 0) {
if(Bid - OrderOpenPrice() > Point * TrailingStop) {
if(OrderStopLoss() < Bid - Point * TrailingStop) {
OrderModify(OrderTicket(), OrderOpenPrice(), Bid - Point * TrailingStop, OrderTakeProfit(), 0, MediumSeaGreen);
if (!EachTickMode) BarCount = Bars;
continue;
}
}
}
} else {
//Close

//+------------------------------------------------------------------+
//| Signal Begin(Exit Sell) |
//+------------------------------------------------------------------+

if (CloseSell1_1 > CloseSell1_2) Order = SIGNAL_CLOSESELL;

//+------------------------------------------------------------------+
//| Signal End(Exit Sell) |
//+------------------------------------------------------------------+

if (Order == SIGNAL_CLOSESELL && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
OrderClose(OrderTicket(), OrderLots(), Ask, Slippage, DarkOrange);
if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Ask, Digits) + " Close Sell");
if (!EachTickMode) BarCount = Bars;
IsTrade = False;
continue;
}
//Trailing stop
if(UseTrailingStop && TrailingStop > 0) {
if((OrderOpenPrice() - Ask) > (Point * TrailingStop)) {
if((OrderStopLoss() > (Ask + Point * TrailingStop)) || (OrderStopLoss() == 0)) {
OrderModify(OrderTicket(), OrderOpenPrice(), Ask + Point * TrailingStop, OrderTakeProfit(), 0, DarkOrange);
if (!EachTickMode) BarCount = Bars;
continue;
}
}
}
}
}
}

//+------------------------------------------------------------------+
//| Signal Begin(Entry) |
//+------------------------------------------------------------------+

if (Buy1_1 > Buy1_2 && Buy2_1 <= Buy2_2) Order = SIGNAL_BUY;

if (Sell1_1 < Sell1_2 && Sell2_1 >= Sell2_2) Order = SIGNAL_SELL;

//+------------------------------------------------------------------+
//| Signal End |
//+------------------------------------------------------------------+

//Buy
if (Order == SIGNAL_BUY && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
if(!IsTrade) {
//Check free margin
if (AccountFreeMargin() < (1000 * Lots)) {
Print("We have no money. Free Margin = ", AccountFreeMargin());
return(0);
}

if (UseStopLoss) StopLossLevel = Ask - StopLoss * Point; else StopLossLevel = 0.0;
if (UseTakeProfit) TakeProfitLevel = Ask + TakeProfit * Point; else TakeProfitLevel = 0.0;

Ticket = OrderSend(Symbol(), OP_BUY, Lots, Ask, Slippage, StopLossLevel, TakeProfitLevel, "Buy(#" + MagicNumber + ")", MagicNumber, 0, DodgerBlue);
if(Ticket > 0) {
if (OrderSelect(Ticket, SELECT_BY_TICKET, MODE_TRADES)) {
Print("BUY order opened : ", OrderOpenPrice());
if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Ask, Digits) + " Open Buy");
} else {
Print("Error opening BUY order : ", GetLastError());
}
}
if (EachTickMode) TickCheck = True;
if (!EachTickMode) BarCount = Bars;
return(0);
}
}

//Sell
if (Order == SIGNAL_SELL && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
if(!IsTrade) {
//Check free margin
if (AccountFreeMargin() < (1000 * Lots)) {
Print("We have no money. Free Margin = ", AccountFreeMargin());
return(0);
}

if (UseStopLoss) StopLossLevel = Bid + StopLoss * Point; else StopLossLevel = 0.0;
if (UseTakeProfit) TakeProfitLevel = Bid - TakeProfit * Point; else TakeProfitLevel = 0.0;

Ticket = OrderSend(Symbol(), OP_SELL, Lots, Bid, Slippage, StopLossLevel, TakeProfitLevel, "Sell(#" + MagicNumber + ")", MagicNumber, 0, DeepPink);
if(Ticket > 0) {
if (OrderSelect(Ticket, SELECT_BY_TICKET, MODE_TRADES)) {
Print("SELL order opened : ", OrderOpenPrice());
if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Bid, Digits) + " Open Sell");
} else {
Print("Error opening SELL order : ", GetLastError());
}
}
if (EachTickMode) TickCheck = True;
if (!EachTickMode) BarCount = Bars;
return(0);
}
}

if (!EachTickMode) BarCount = Bars;

return(0);
}
//+------------------------------------------------------------------+

void activatebreakeven(int MagicNumber)
{
for(int i=0;i<OrdersTotal();i++)
{
if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES)==false) break;
if((OrderMagicNumber()!= MagicNumber || OrderSymbol()!=Symbol()))continue;

if(OrderType() == OP_BUY)
{
if((Bid-OrderOpenPrice()) > (Point*breakeven) && (OrderStopLoss()< OrderOpenPrice()))
OrderModify(OrderTicket(),OrderOpenPrice(),OrderOpenPrice()+(Point*addbreak),OrderTakeProfit(),0,Lime);
}

if(OrderType() == OP_SELL)
{
if((OrderOpenPrice()-Ask) > (Point*breakeven) && (OrderStopLoss()> OrderOpenPrice()))
OrderModify(OrderTicket(),OrderOpenPrice(),OrderOpenPrice()-(Point*addbreak),OrderTakeProfit(),0,Red);
}
}
}l.

qjol 2010.11.25 19:07 #1

please attach the file or at least

[Deleted] 2010.11.25 19:13 #2

qjol:

please attach the file or at least

qjol 2010.11.25 19:14 #3

u sure error 402

[Deleted] 2010.11.25 19:32 #4

qjol:

u sure error 402

Sorry, 4202.

[Deleted] 2010.11.25 19:42 #5

This is the one that gave me the 4202....

Files:

maribbonbreakeventime1.mq4 12 kb

gordon 2010.11.25 19:56 #6

Go over runtime errors and search for 4202 -> check each function that might produce it in your code. It shouldn't be too hard to find the problem.

[Deleted] 2010.11.25 20:18 #7

gordon:
Go over runtime errors and search for 4202 -> check each function that might produce it in your code. It shouldn't be too hard to find the problem.

These are the errors I am getting. Ill take a look at the runtime errors. Thanks.

2010.11.25 11:29:03 2010.04.01 15:15 vHandsTrade EURUSD,H4: ObjectSetText( "Swap_28", "", 8"Arial", 0 ) - Error #4202
2010.11.25 11:29:03 2010.04.01 15:15 vHandsTrade EURUSD,H4: ObjectSetText( "CurPrice_28", "", 8"Arial", 0 ) - Error #4202
2010.11.25 11:29:03 2010.04.01 15:15 vHandsTrade EURUSD,H4: ObjectSetText( "TakeProfit_28", "", 8"Arial", 0 ) - Error #4202
2010.11.25 11:29:03 2010.04.01 15:15 vHandsTrade EURUSD,H4: ObjectSetText( "StopLoss_28", "", 8"Arial", 0 ) - Error #4202
2010.11.25 11:29:03 2010.04.01 15:15 vHandsTrade EURUSD,H4: ObjectSetText( "OpenPrice_28", "", 8"Arial", 0 ) - Error #4202
2010.11.25 11:29:03 2010.04.01 15:15 vHandsTrade EURUSD,H4: ObjectSetText( "Lots_28", "", 8"Arial", 0 ) - Error #4202
2010.11.25 11:29:03 2010.04.01 15:15 vHandsTrade EURUSD,H4: ObjectSetText( "Type_28", "", 8"Arial", 0 ) - Error #4202

Trading simulators! i Have added a Errors, bugs, questions

qjol 2010.11.25 20:40 #8

i'm sorry but u get that error from vHandsTrade.mq4 & not from the expert u have attached above, another thing u dont use this function (ObjectSetText()) in the EA's u attached

[Deleted] 2010.11.26 17:29 #9

qjol:

i'm sorry but u get that error from vHandsTrade.mq4 & not from the expert u have attached above, another thing u dont use this function (ObjectSetText()) in the EA's u attached

Your right...it works perfectly now, just needed some fine tuning. Once i used it without vhands, it worked great.

One more question, if I wanted to add it to buy RSI 9 over 55 and sell when below 45, how would I add that. So the ea would need to buy/sell once the ma's cross and the RSI 9 is above the 55 and below the 45. Thanks for everyone's help.

How to make my Need Help in Trade Rsi Ea

William Roeder 2010.11.26 19:34 #10

iRSI()

New comment