Error '(' - function definition unexpected

New comment
 

Hi all,

 

In code I get the error message  '(' - function definition unexpected, Could anyone help me to get this right ?

In attach is  all the code and in Bold is where I suppose the problem is, nevertheless I've been uncessuful to get it right. 

Ticket=OrderSend(Symbol(),OP_BUY,LotSize,Ask,RealSlippage,0,0,"Buy Order",MagicNumber,0,Green);
             if(Ticket>0)AddLimitsBuy();
void AddLimitsBuy()
   {
     OrderSelect(Ticket,SELECT_BY_TICKET);

 Thanks in advance for any help you cloud provide

 Luis 

Files:
marketforderuecnnv12.mq4  10 kb
 
You desperately need to sort out your indenting . . .  where is the end of your start() function ?  user defined functions go outside of any other functions,  NOT inside. 
 

Hi Raptor,

 

Thank you for your prompt response (and open mind with me). I will take your clue and try to get that.

 

Best Regards

Luis  

 

Hi RaptorUk,

Two questions,

When you say proper indenting is that meaning to have close brackets for any open brackets ? 

Is that possible to take off the void from the function name CloseAll () in the sense to include it in the start function and at the very end put

return(0); 

}

Best regards

 Luis 

 
luisneves:

Hi RaptorUk,

Two questions,

When you say proper indenting is that meaning to have close brackets for any open brackets ?  

I mean instead of this . . . .

void AddLimitsBuy()
          {
           OrderSelect(Ticket,SELECT_BY_TICKET);
           OpenPrice = OrderOpenPrice();

       StopLevel = MarketInfo(Symbol(),MODE_STOPLEVEL)*Point;
                                       RefreshRates();  
                                       UpperStopLevel = Ask + StopLevel;
                                       LowerStopLevel = Bid - StopLevel;
                                       
                                      
                                      if(StopLoss > 0)   double BuyStopLoss   = OpenPrice - (StopLoss * pt);
                  if(TakeProfit > 0) double BuyTakeProfit = OpenPrice + (TakeProfit * pt);
                                      
                                      if(BuyStopLoss > 0 && BuyStopLoss > LowerStopLevel) 
                                              {                                 
                                                    BuyStopLoss = LowerStopLevel - MinStop*pt;
                                              }
                                      
                                      if(BuyTakeProfit > 0 && BuyTakeProfit < UpperStopLevel) 
                                              {
                                                     BuyTakeProfit = UpperStopLevel + MinStop*pt;
                                              }

                                      if(IsTradeContextBusy())Sleep(10);        

                  if(BuyStopLoss > 0 || BuyTakeProfit > 0) 
                     {          
                      OrderModify(Ticket,OP_BUY,BuyStopLoss,BuyTakeProfit,0);                            
                     }
                    }

you have this . . .

void AddLimitsBuy()
   {
   OrderSelect(Ticket,SELECT_BY_TICKET);
   OpenPrice = OrderOpenPrice();
   
   StopLevel = MarketInfo(Symbol(),MODE_STOPLEVEL)*Point;
   RefreshRates();
   UpperStopLevel = Ask + StopLevel;
   LowerStopLevel = Bid - StopLevel;

   if(StopLoss > 0)
      double BuyStopLoss   = OpenPrice - (StopLoss * pt);

   if(TakeProfit > 0)
      double BuyTakeProfit = OpenPrice + (TakeProfit * pt);
   
   if(BuyStopLoss > 0 && BuyStopLoss > LowerStopLevel)
      {
      BuyStopLoss = LowerStopLevel - MinStop*pt;
      }
   
   if(BuyTakeProfit > 0 && BuyTakeProfit < UpperStopLevel)
      {
      BuyTakeProfit = UpperStopLevel + MinStop*pt;
      }
   
   if(IsTradeContextBusy())Sleep(10);
   
   if(BuyStopLoss > 0 || BuyTakeProfit > 0)
      {
      OrderModify(Ticket,OP_BUY,BuyStopLoss,BuyTakeProfit,0);
      }
   }
 
luisneves:


Is that possible to take off the void from the function name CloseAll () in the sense to include it in the start function and at the very end put

return(0); 

}

If you don't want it to be a user defined function and want that code to always run for every tick then yes . . .  you would also remove  CloseAll()
 

Hi RaptorUK, (again....)

 

I'm lost!!!

I've tried to do my up most to get this working, but without success.

First, I've include in just one block the get profit and close all orders and put it inside the start block.

Second I've let the AddLimitsBuy  and AddLimitsSell  functions as separate because I don't know how to call those functions very time an order is opened.

and for last the irritating error is there and I do not find a way to get rid of it.....

These are the two blocks of code that I try to get in only one

 Any help here (if you still having patience)?

Best Regards

Luis 

 

{
  int pos;
  int Total=OrdersTotal();
  if(Total>0)
 {
  for(int Profit=OrdersTotal()-1;pos>=0;pos--)
  if(OrderSelect(Profit,SELECT_BY_POS)
  && OrderMagicNumber()==MagicNumber && OrderSymbol()==Symbol()
  && TakeProfit-OrderOpenPrice()>TakeProfit)CloseAll();  
 }
}

 

 void CloseAll()
      {
         int i,Op,Error;
         int Total=OrdersTotal();
     
         if(Total>0)
         {
         for(int pos=OrdersTotal()-1;pos>=0;pos--)
         if(OrderSelect(pos,SELECT_BY_POS)
         && OrderMagicNumber()==MagicNumber && OrderSymbol()==Symbol())
         {
         Op=OrderType();
         if(Op==OP_BUY)
         {
         OrderClose(OrderTicket(),OrderLots(),Bid, UseSlippage, Yellow);
         }
         if(Op==OP_SELL)
         {
         OrderClose(OrderTicket(),OrderLots(),Ask, UseSlippage, Yellow);
         }
         else
         {
         ObjectDelete("highline");
         }
        }
       }
      }

 

 Mix of last two blocks:

// Close All(close all open positions if last one reach TakeProfit)

int OrdType, GLError;
    RefreshRates();     
              
    for(int OrderPos = OrdersTotal()-1; OrderPos >= 0; OrderPos--)
       if(OrderSelect(OrderPos, SELECT_BY_POS, MODE_TRADES)
          && OrderMagicNumber()== MagicNumber && OrderSymbol()== Symbol()
          &&(OrderProfit() + OrderSwap() + OrderCommission() > 0 )
         {
         OrdType = OrderType();
       if(OrdType == OP_BUY || OrdType==OP_SELL)
           {
           if(!OrderClose(OrderTicket(), OrderLots(), OrderClosePrice(), RealSlippage, Yellow))
               GLError = GetLastError();
           }
         else
          {
         ObjectDelete("highline");
         }
       if(GLError > 0) Print("Error Closing/Deleting Order, error # ", GLError, " for ticket: ", OrderTicket());
        }
       }
      }
      return(0);
     }
Files:
marketkorderiecnmv12.mq4  12 kb
 
luisneves:

Hi RaptorUK, (again....)

Any help here (if you still having patience)?

I have plenty of patience but I can't afford to spend hours trying to understand your code . . . .  this is why I mentioned before that you need to add comments to explain what sections/functions of your code are trying to do.
 

Hi RaptorUk,

I understand your position and thank you for your support.

In the attach file sent  have divide the whole code by blocks where on top is the main function of each one. Nevertheless at this very moment I'm write down more comments to better communicate what kind of results I'm looking from each one.

Thank you again for your support

 Best Regards

Luis 

 

Hi RaptorUk,

 Here in attach is the whole code with a description of every function required.

I really appreciate a look and support.

 

Best regards

Luis 

Files:
marketnordernecnrv12.mq4  15 kb
 
luisneves:

Hi RaptorUk,

 Here in attach is the whole code with a description of every function required.

I really appreciate a look and support.

It compiles now . . .  I fixed the compile issues, nothing else other than some more indenting so I could follow the flow.
123
New comment
Reason: